Feat: Expose validity time to command line

@haufs @qingtian Current feature allows to set starting date of validity period of calibration constant using parameter of the notebook. Default value is equal to injection time (begin_at).

I would suggest a test when the new data is applied. From my side, LGTM.

Doesn't use_dir_creation_date already do the same thing as the default, just taking the file date? This can lead to conflicting settings: begin_validity == "INJECTION" and use_dir_creation_date=False results in the current time being used, which is not obvious from that configuration.

Also, do not use the following construct:

if not foo == "bar":

The correct way is:

if foo != "bar":

Once solution might be:

overwrite_validity_start = ""

If empty no overwrite is performed, if not, it is always overwritten.

added 1 commit

• cef43c4b - Remane parameter begin validity

Compare with previous version

Done. Variable was renamed to overwrite_validity_start. Code was tested.

LGTM, but please first change

 metadata.calibration_constant_version = Versions.FromFile(device=device,
                                                           file_path= filename)

to

 metadata.calibration_constant_version = Versions.FromFile(device=device,
                                                           file_path=ped_dir)

LGTM except for a minor one:

use_dir_creation_date = True in the first cell should be False as a default value, though it might be True in your tests.

added 1 commit

• 93923b9d - Use directory instaed of file to extract creation time

Compare with previous version

use_dir_creation_date = True is not a part of this commit.

Directory of files is now used to extract creation time instead of filename.

merged

mentioned in commit 75e95b57