Skip to content

[REMI] Add compatibility with old DAQ files

Philipp Schmidt requested to merge fix/remi-old-files into master

Description

When building the output files, the current REMI reconstruction code assumes daqLibrary=1.0 fields to be present. SQS recently tried to reconstruct runs from 2019, which were still lacking this fields and thus causing the notebook to throw an exception. This MR preserves the output format, but catches old files by supplying default values.

Also fixes a bug in edge trigger code (only used for old data) and fixes a potential exception in plotting code when there's no signal in the data, which a corresponding MR in EXtra-remi: https://git.xfel.eu/dataAnalysis/EXtra-remi/-/merge_requests/1

How Has This Been Tested?

run = 100
in_folder = '/gpfs/exfel/exp/SQS/201802/p002159/raw'
calib_config_path = '/gpfs/exfel/exp/SQS/201802/p002159/usr/remi_proc_config.yaml'

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Reviewers

@ahmedk @kluyvert

Merge request reports