Skip to content

Feat: Expose the CCV `variant` to cal_tools sending and retrieving and expose it in agipdlib

Karim Ahmed requested to merge feat/ccv_tag into master

Exposing CCV variant in the send_to_db and get_from_db functions and as well in agipdlib. So it can be later used with https://git.xfel.eu/detectors/pycalibration/-/merge_requests/604 to inject CCV of v1 indicating an already sanitized PC constants.

After this MR and updating https://git.xfel.eu/detectors/pycalibration/-/merge_requests/604. A required change will be needed to use this variant in avoiding PC sanitization. https://git.xfel.eu/detectors/pycalibration/-/blob/cf9bc1dffccbcfdaccc87d7c0db2f619af5021d2/src/cal_tools/agipdlib.py#L1138-1153

Description

A new feature is introduced in cal_db_interactive https://git.xfel.eu/detectors/cal_db_interactive/-/merge_requests/79 to have a variant attribute for calibration_constant_version. This variant is an integer pointing on how to handle the constant data before usage in corrections.

Later this feature can be used by https://git.xfel.eu/detectors/pycalibration/-/merge_requests/604. As with these PC changes correction time can be saved by avoiding constant sanitization post retrieval.

NOTE: As it was pointed out in the MR discussions below. It is very important to document the properties of each variant at least in the code after introducing one.

How Has This Been Tested?

Relevant Documents (optional)

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Update setup.py with the correct iCalibrationDB tag

Reviewers

@kluyvert @schmidtp

Edited by Karim Ahmed

Merge request reports