[EPIX100] [DARK]Adding Bad Pixels Map

Description

• Generates the bad pixel map.
• Added badpixel_threshold_sigma input variable: Number of standard deviations considered for bad pixel classification.
• Sensor size is read from hdf5 file instead of being manually input.

How Has This Been Tested?

• Running the notebook
• Terminal command "xfel-calibrate EPIX100 DARK"

Types of changes

• New feature (non-breaking change which adds functionality)

Checklist:

Reviewers

@ahmedk @danilevc

added 1 commit

• a395aa7f - adding bad pixel map

Compare with previous version

Hi Nuno, nice seeing you in here. Welcome!

Tagging @ahmedk as he's the most familiar with this particular notebook.

marked this merge request as ready

changed the description

changed the description

changed title from Adding Bad Pixels Map to [EPIX100] [DARK]Adding Bad Pixels Map

added 7 commits

• a395aa7f...22023f3f - 4 commits from branch master
• 7e94b070 - Adding Bad Pixels Map
• dcfa5b6f - adding bad pixel map
• a703a09c - reviewed version

Compare with previous version

added 1 commit

• f677471c - reviewed version 2

Compare with previous version

I committed the reviewed version. It is commit "f677471c - reviewed version 2". Please ignore the previous commit (a703a09c - reviewed version), it was a failed commit attempt from a GitLab noob.

Here are the main changes in this commit:

• Renamed pixel_data to pixels_src
• Renamed constant_maps['BadPixels'] to constant_maps['BadPixelsDark']
• Use as_single_value() to read sensor_size and integration_time
• Possibility of manual input of integration_time
• Changed default fix_temperature value from 0 to -1, if intendeed to read from h5 file (to keep consistency with integration_time).
• Minor modifications to printed operation conditions on cell 5
• Removed spaces around = inside functions (PEP8 guide)

added Waiting for review label

added 1 commit

• 466b5608 - sensor_size compatible with old data

Compare with previous version

resolved all threads

Thank you @duarten for this nice MR.

I have no further comments, LGTM.

Let's wait for another LGTM from another reviewer, so I can later merge this MR.