[AGIPD][TESTs]test_agipdlib AGIPDCtrl and get_bias_voltage for AGIPD1M and AGIPD500K

Based on https://git.xfel.eu/detectors/pycalibration/-/merge_requests/651

• Test AGIPDCtrl() methods to read conditions from Fast or slow data.
• differentiate between AGIPD1M and AGIPD500K sources and keys to read bias_voltage. (temporary unbreakable change.)

Description

Latest changes to agipdlib had a class AGIPDCtrl() created collecting all methods to read AGIPD parameter conditions from fast and slow data.

1. I have added tests for these methods
2. I have split some methods based on their functionality.
3. As bias_voltage is stored in different paths for AGIPD1M and AGIPD500K, a condition was added to select the right source.

• This is a temporary change and I think one should give the correct source and key through get_bias_voltage arguments.

4. All of the tests are based on EXtra-data mocked data. I have added mock_agipd1m_run, mock_agipd500K_run and mock_agipd1m_run_old at :

How Has This Been Tested?

Unit tests.

Relevant Documents (optional)

Types of changes

• Test (additional or refactored tests)

Checklist:

• My code follows the code style of this project.
• I have updated the documentation accordingly.
• I added tests where appropriate.

Reviewers

@calibration

src/cal_tools/agipdlib.py

@@ -28,6 +28,7 @@ from cal_tools.h5_copy_except import h5_copy_except_paths
 from cal_tools.tools import get_from_db
 
 
+
 class AgipdCtrl:
     def __init__(
         self,
@@ -81,6 +82,9 @@ class AgipdCtrl:
             # about bucketing the rate for managing meta-data.
             return round(float(self.run_dc[rep_rate_src].as_single_value()), 1)
 
+    def _get_acq_rate_instr(self) -> Optional[float]:
+        """Get acquisition (repetition rate) from INSTRUMENT source."""
+
     def _get_acq_rate_instr(self) -> Optional[float]:
         """Get acquisition (repetition rate) from INSTRUMENT source."""
 
@@ -135,7 +139,7 @@ class AgipdCtrl:
         Returns:
             int: gain_setting value.
         """
-        setupr = self.run_dc[self.ctrl_src, "setupr.value"].as_single_value()
+        setupr = self.run_dc[self.ctrl_src, "setupr"].as_single_value()
         pattern_type_idx = self.run_dc[
             self.ctrl_src, "patternTypeIndex"].as_single_value()
 
@@ -218,7 +222,7 @@ class AgipdCtrl:
 
         :param karabo_id_control: The karabo deviceId for the CONTROL device.
         :param module: defaults to module 0
-        :return: voltage, a uint16
+        :return: bias voltage
         """
         # TODO: Add a breaking fix by passing the source and key through
         # get_bias_voltage arguments.
@@ -257,6 +261,7 @@ class AgipdCtrl:
                 raise ValueError(error)
             return default_voltage
 
+
     def get_integration_time(self) -> int:
         """Read integration time from the FPGA device.