Skip to content
Snippets Groups Projects

[AGIPD] Read bias_voltage for AGIPD at SPB and MID from RUN source

Merged Karim Ahmed requested to merge fix/get_bias_voltage_SPB_MID into master
All threads resolved!

get_bias_voltage() read bias_voltage for HED_DET_AGIPD500K2G only.

Description

Start using SPB_DET_AGIPD1M/PSC/HV/channels.U0.measurementSenseVoltage.value and MID_DET_AGIPD1M/PSC/HV/channels.U0.measurementSenseVoltage.value to ready bias voltage for SPB_DET_AGIPD1M-1 and MID_DET_AGIPD1M-1.

How Has This Been Tested?

Relevant Documents (optional)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@calibration

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Karim Ahmed changed the description

    changed the description

  • Karim Ahmed added 1 commit

    added 1 commit

    • ac3dff5c - only go to default value for SPB and MID and correct PSC source

    Compare with previous version

  • Karim Ahmed changed the description

    changed the description

  • Karim Ahmed changed the description

    changed the description

  • Karim Ahmed changed title from Read bias_voltage for AGIPD at SPB and MID from RUN source to [AGIPD] Read bias_voltage for AGIPD at SPB and MID from RUN source

    changed title from Read bias_voltage for AGIPD at SPB and MID from RUN source to [AGIPD] Read bias_voltage for AGIPD at SPB and MID from RUN source

  • Philipp Schmidt changed milestone to %3.5.1

    changed milestone to %3.5.1

  • Karim Ahmed added 30 commits

    added 30 commits

    • ac3dff5c...ea1b0f06 - 28 commits from branch master
    • 632a1228 - Read bias_voltage for AGIPD at SPB and MID from RUN source
    • ecfbb724 - only go to default value for SPB and MID and correct PSC source

    Compare with previous version

  • Thomas Kluyver
  • Karim Ahmed added 1 commit

    added 1 commit

    • 2de24b3d - add comment on using get_run_value instead of as_single_value

    Compare with previous version

  • OK, this looks fine to me, then. If it's meant as a temporary change, there's no point thinking too hard about the best way to design the check. :slight_smile:

  • Thank you @kluyvert for the review :)

  • Karim Ahmed resolved all threads

    resolved all threads

  • merged

  • Karim Ahmed mentioned in commit 477189d2

    mentioned in commit 477189d2

  • Please register or sign in to reply
    Loading