[AGIPD] Split AGIPDCtrl function for clear code and adding tests later.

Based on changes in MR : https://git.xfel.eu/detectors/pycalibration/-/merge_requests/652

This MR is a preparation for the next MR for adding unit tests https://git.xfel.eu/detectors/pycalibration/-/merge_requests/646

Description

• Separate get_gain_setting() and get_acq_rate() into two different functions which read the gain_settings and acquisition rate using two different methods.

• Small refactors:

  • correct hint typing for get_gain_mode()
  • correct the doc string for get_num_cells()
  • correct the doc string for AGIPDCtrl()

How Has This Been Tested?

Relevant Documents (optional)

Types of changes

Checklist:

• I added tests where appropriate. In a separate MR: https://git.xfel.eu/detectors/pycalibration/-/merge_requests/646

Reviewers

@calibration

added 2 commits

• 0de39705 - 1 commit from branch fix/get_run_value_AGIPDCtrl
• 5dceb0c9 - use get_run_value instead of as_single_value and split functions for adding tests later

Compare with previous version

changed the description

added 2 commits

• 247b8695 - 1 commit from branch fix/get_run_value_AGIPDCtrl
• ddca1463 - use get_run_value instead of as_single_value and split functions for adding tests later

Compare with previous version

added 1 commit

• 4db7c4a5 - fix function names

Compare with previous version

added 1 commit

• 69cc4336 - fix function names

Compare with previous version

added In Progress label

deleted the fix/get_run_value_AGIPDCtrl branch. This merge request now targets the master branch

added 62 commits

• 69cc4336...1df6b681 - 59 commits from branch master
• b3637440 - change from get_run_value to as_single_value
• 68bac535 - use get_run_value instead of as_single_value and split functions for adding tests later
• 6b3108d5 - fix function names

Compare with previous version

marked this merge request as ready

removed In Progress label

added Waiting for review label

changed title from Split AGIPDCtrl function for clear code and adding tests later. to [AGIPD] Split AGIPDCtrl function for clear code and adding tests later.

changed the description

added 1 commit

• 40370cf4 - fix function names

Compare with previous version

added 102 commits

• 40370cf4...9ddc981d - 99 commits from branch master
• f4ca8b32 - change from get_run_value to as_single_value
• ab719031 - use get_run_value instead of as_single_value and split functions for adding tests later
• 501c3c98 - fix function names

Compare with previous version

mentioned in merge request !646 (merged)

added 1 commit

• 7e1bd60d - explain what is old RAW data

Compare with previous version

resolved all threads

resolved all threads

resolved all threads

With the inclusion of a date for "old data", very happy with it, thanks! It definitely makes this whole compatibility stuff around different versions of data clearer. LGTM!

added 1 commit

• 7fcd6a0e - explain what is old RAW data

Compare with previous version

resolved all threads

changed the description

added 1 commit

• 7e1bd60d - explain what is old RAW data

Compare with previous version

@ahmedk Can this be merged?

changed milestone to %3.6.0

I hoped for more than one LGTM. But I agree that we should merge it considering how long it was open.

Thank you for the review @schmidtp

merged

mentioned in commit 38661a7f

removed Waiting for review label