[AGIPD][DARK] fix gain mode validation for FIXED_GAIN operation mode

Review changes
Download
Patches
Plain diff

Merged [AGIPD][DARK] fix gain mode validation for FIXED_GAIN operation mode

fix/operation_mode_fixed_gain_selected into master

Overview 25
Commits 5
Pipelines 0
Changes 1

Merged Karim Ahmed requested to merge fix/operation_mode_fixed_gain_selected into master 2 years ago

Overview 25
Commits 5
Pipelines 0
Changes 1

A fix for selecting Fixed_Gain operation mode for fixed gain dark runs. Related to this ticket https://in.xfel.eu/redmine/issues/125424

Description

The Dark notebook didn't depend much on selecting the correct operation mode, to avoid operator mistakes by requesting darks for fixed gain runs with ADAPTIVE GAIN operation mode.

Ironically when the operator selected the correct configuration for the runs. The notebook failed with the wrong conditions.

This MR fixes this mess.

Removing this undefined runs parameter.
Fix the conditions in case FIXED_GAIN is selected.
Move all the validation for gain_mode parameter in validate_gain_modes

How Has This Been Tested?

Running the notebook interactively for the runs mentioned in the problem ticket

Relevant Documents (optional)

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@schmidtp @tmichela @hammerd

Edited 2 years ago by Karim Ahmed

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

Request review from

Labels

None

Select labels

Manage project labels

Milestone

None

Time tracking

No estimate or time spent

0 Participants

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.