[AGIPD][LPD][DSSC][DARK] Avoid printing errors for expected missing constant files
Avoid printing errors or warnings if constant files as ´ThresholdsDark´ are missing.
This is can be the case for Fixed Gain AGIPD, LPD and DSSC
Description
This generic notebook needs to be refactored. I minimized the changes for now by removing the warning of a constant file that is not available.
How Has This Been Tested?
Relevant Documents (optional)
Types of changes
- Bug fix (non-breaking change which fixes an issue)
Checklist:
Reviewers
Merge request reports
Activity
changed milestone to %3.5.2
added Waiting for review label
- Resolved by Karim Ahmed
Has it ever been useful to indicate that the output files are missing, i.e. are we possibly removing an opportunity to indicate an actual error state?
It seemed like the
operation_mode
parameter is part of the protocol, so we could condition this for things like fixed gain and thresholds?
added 1 commit
- fbbf1e78 - different expected constants and check AGIPD constants for FIXED or ADAPTIVE gain mode operation
added 1 commit
- ff5763d9 - different expected constants and check AGIPD constants for FIXED or ADAPTIVE gain mode operation
- Resolved by Karim Ahmed
With the
AgipdCtrl
class, is it easy to determine the gain mode in the per-detector-branch and only addThresholdsDark
if appropriate?
added 1 commit
- aaa69230 - different expected constants and check AGIPD constants for FIXED or ADAPTIVE gain mode operation
added 48 commits
-
aaa69230...c17d7ff5 - 46 commits from branch
master
- ba1f0e50 - avoid printing errors of missing constant files
- d5b48267 - different expected constants and check AGIPD constants for FIXED or ADAPTIVE gain mode operation
-
aaa69230...c17d7ff5 - 46 commits from branch
changed milestone to %3.5.3
changed milestone to %3.6.0
added 55 commits
-
d5b48267...31882ca3 - 53 commits from branch
master
- 31b8b753 - avoid printing errors of missing constant files
- 43f4dca6 - different expected constants and check AGIPD constants for FIXED or ADAPTIVE gain mode operation
-
d5b48267...31882ca3 - 53 commits from branch
Thank you @schmidtp
mentioned in commit 2023a80e
removed Waiting for review label