Skip to content

[LPD] New correction notebook

Philipp Schmidt requested to merge feat/LPD-revival into master

Description

In discussion about the offline corrections in preparation of the FXE-SFX beamtime next week, I've decided to write an entirely new notebook instead of changing the existing one to accommodate Hazem's correction scheme. A major motivation was the very slow performance of the existing notebook due to np.choose among other things.

I used this opportunity to try out using existing DA machinery from the ground up as much as possible and designing it around extra_data, extra_geom, pasha etc. Since the CorrectionData API is not yet ready, I've ditched iCalibrationDB for a couple calls to calibration_client directly.

Currently targeting feat/calcat-credentials to keep the diff smaller.

How Has This Been Tested?

xfel-calibrate LPD CORRECT --in-folder /gpfs/exfel/exp/FXE/202201/p003073/raw/ --out-folder /gpfs/exfel/data/scratch/schmidtp/random/LPD_test --sequences 0 --run 10

Types of changes

  • New feature (non-breaking change which adds functionality)

Reviewers

@ahmedk @danilevc @kluyvert @yousefh @khakhuli

Merge request reports