Skip to content
Snippets Groups Projects

Fix trying to use report-to name for karabo-id when report is skipped

Merged Fix trying to use report-to name for karabo-id when report is skipped
fix/xfel-calibrate-no-report-to into master
All threads resolved!
Merged Philipp Schmidt requested to merge fix/xfel-calibrate-no-report-to into master
All threads resolved!

Description

A peculiar problem that came up when @tmichela tried to use the HED ONC setup with PPU train selection and skipping all kind of things with the current tag. Turns out that --skip-report introduced the notion of report-to being actually an empty string. Some recent changes in https://git.xfel.eu/detectors/pycalibration/-/merge_requests/661 missed this unfortunately and tried to use report_to.name as a default Karabo domain. While report_to is guaranteed to be a Path object, this only for it being non-empty!

This MR tries to fix this by preserving the existing behaviour when report-to has a value, and computing a SHA1 hash from the job IDs if not. This may be overly cautious, but I wanted to make sure it's a unique values and the slurm_out is never overwritten.

How Has This Been Tested?

Tested by @tmichela with the OfflineCalRunner device at HED

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Reviewers

@tmichela @kluyvert

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thomas Kluyver
    Thomas Kluyver @kluyvert ·
    Owner

    LGTM

  • Philipp Schmidt resolved all threads

    resolved all threads

  • Philipp Schmidt merged

    merged

  • Philipp Schmidt mentioned in commit 9a1eacd3

    mentioned in commit 9a1eacd3

  • Philipp Schmidt removed Waiting for review label

    removed Waiting for review label

    • Please register or sign in to reply

    Legal Notice | Contacts