[EXtra-data] Disable _use_voview to be able to use .files
With the multiple changes in extra-data after version 1.9.1 .
A test was done to validate that pycalibration works fine and a needed change for using DataCollection.files
was needed after the virtual_overview_version
was introduced in extra-data.
Description
With latest changes in Extra-data using DataCollection.files
is not guaranteed to show the files for the selected sources.
The .files
method was used in some correction notebooks and AGIPD dark to get a list of the files for the selected sources.
A solution would be to avoid using this method and glob the files in the folder as was done before or avoid matching and disable the virtual_overview_version from the RunDirectory
function when used.
The latter solution is introduced in the MR along with the update for extra-data version.
How Has This Been Tested?
Using the automated testing https://git.xfel.eu/detectors/pycalibration/-/merge_requests/610 on all reference runs.
Relevant Documents (optional)
Types of changes
- Bug fix (non-breaking change which fixes an issue)
Checklist:
- My code follows the code style of this project
Reviewers
Merge request reports
Activity
- Resolved by Karim Ahmed
- Resolved by Karim Ahmed
- Resolved by Karim Ahmed
added 6 commits
-
3efa5fce...31882ca3 - 4 commits from branch
master
- 246dd3d0 - _uscancel e_voview to be able e to use .files
- 84f737cb - lose .files from AGIPD dark and FF
-
3efa5fce...31882ca3 - 4 commits from branch
Thank you @kluyvert
Merging by today if there are no more comments
mentioned in commit 6d5a02b4
changed milestone to %3.6.0