Skip to content
Snippets Groups Projects

JUNGFRAU: Mask double-size pixels

Merged David Hammer requested to merge feat/jf_mask_double_size_pixels into master
All threads resolved!

Requested by Marcin who included the following screenshot to demonstrate the bright double-size pixels:

Screenshot_from_2022-06-11_16-25-52

Doing the actual masking is not that hard: for now, I've added a few lines to (if mask_double_size_pixels) set the corresponding rows / columns* in bad pixels mask to 1**. Details to discus:
*Have asked for confirmation about the exact pixels. Seems like all ASIC borders.
**Would want a good bad pixel field to set. Maybe we reuse one of the existing bad pixel fields or add one?

Edited by David Hammer

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • David Hammer marked this merge request as ready

    marked this merge request as ready

  • David Hammer added 1 commit

    added 1 commit

    • a5a8792a - Remove spurious line from rebase

    Compare with previous version

  • David Hammer
  • Thank you @hammerd , LGTM

  • Thanks for the review!

  • merged

  • David Hammer mentioned in commit 1504d8f4

    mentioned in commit 1504d8f4

  • David Hammer resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading