Skip to content
Snippets Groups Projects

New calcat interface

Merged Karim Ahmed requested to merge feat/new_calcat_interface into master

The MR is based on the work done on this MR in EXtra-data: https://github.com/European-XFEL/EXtra-data/pull/262

New CALCAT interface to replace calibrationDBRemote, iCalibrationDB, and cal_tools.get_from_db for retrieving constants from CALCAT.

Related to https://git.xfel.eu/calibration/planning/-/issues/150

Description

How Has This Been Tested?

  • Has been tested along with all the correction notebooks and detectors available. Reference runs

Relevant Documents (optional)

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Update snapshot parameter after calibration client is updated.
  • I updated the documentation accordingly.
  • I added tests where appropriate.

Reviewers

@kluyvert @schmidtp

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • I've already reviewed the CalibrationData API somewhat in the EXtra-data PR, so I'm pretty happy with that - certainly happy enough to start using it in internal code.

    • I have added comments on the new pieces that I added/changed from the version in EXtra-data PR. Beside these tiny changes. I have added missing detectors, but they are following the same structure as the detectors available before. So there is nothing new there.

    • Please register or sign in to reply
  • Karim Ahmed added 1 commit

    added 1 commit

    • 1a637f94 - change calibration.py to calcat_interface.py and refactors

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    • 32c0b216 - retest epix100 and add warning

    Compare with previous version

  • Karim Ahmed added 90 commits

    added 90 commits

    • 32c0b216...a97b9bc1 - 86 commits from branch master
    • 05af7f70 - Draft: new calcat interface and corresponding updates in the correction notebook
    • cfd2eff4 - Expose calcat_interface in the docs
    • 568a82b9 - change calibration.py to calcat_interface.py and refactors
    • b951ca00 - retest epix100 and add warning

    Compare with previous version

  • Thomas Kluyver mentioned in merge request !767 (merged)

    mentioned in merge request !767 (merged)

  • Karim Ahmed added 1 commit

    added 1 commit

    • 1ce01a8d - calcat_interface_lpd_epix_jf

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    • 8544bc11 - update calcat_interface after testing notebooks

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading