Skip to content
Snippets Groups Projects

Avoid unclear errors when jungfrau run has no trains to correct

Merged Karim Ahmed requested to merge fix/no_trains_jungfrau_correct into master
All threads resolved!

If a Jungfrau run has no trains to correct, the notebook fail with unclear message related to the step_timer.

Description

  • Fix StepTimer.timespan() if timings were still None.
  • Use from logging import warn for no trains for a sequence displayed WARNING.
  • Fail if there is no RAW sequence file to correct. (All sequence files are empty.)

How Has This Been Tested?

Tested with run /gpfs/exfel/exp/HED/202202/p003048/usr/Reports/r106/HED_IA1_JF500K1_correct_003048_r106_221104_081650.pdf

Relevant Documents (optional)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@schmidtp @kluyvert

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thomas Kluyver
  • Thomas Kluyver
  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • Karim Ahmed resolved all threads

    resolved all threads

  • Thank you @kluyvert !

  • merged

  • Karim Ahmed mentioned in commit a97b9bc1

    mentioned in commit a97b9bc1

  • Philipp Schmidt changed milestone to %3.7.3

    changed milestone to %3.7.3

  • Please register or sign in to reply
    Loading