Skip to content
Snippets Groups Projects

[JUNGFRAU][CORRECT][ROI] Fix storing multiple ROIs Instrument datasets and run keys

Merged Karim Ahmed requested to merge fix/Trying_to_recreate_Instrument/Control/sections into master

I realized that the last FXE_XAD_JF1M corrections failed: /gpfs/exfel/exp/FXE/202231/p900298/usr/Reports/r255/FXE_XAD_JF1M_correct_900298_r255_221111_033250.pdf

The reason was a bug when trying to add multiple ROI for the same module.

THIS IS CURRENTLY HOTFIXED IN PRODUCTION.

Description

ValueError: Unable to create group (name already exists) is faced when trying to recreate the INSTRUMENT section.

This is a bug introduced at : release 3.7.2 https://git.xfel.eu/detectors/pycalibration/-/merge_requests/735

While testing I didn't use multiple ROIs for the same module.

How Has This Been Tested?

I ran it on the failed correction. document.pdf

Relevant Documents (optional)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@kluyvert @schmidtp

Edited by Karim Ahmed

Merge request reports

Checking pipeline status.

Merged by Philipp SchmidtPhilipp Schmidt 2 years ago (Nov 15, 2022 6:28am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading