Skip to content
Snippets Groups Projects

[PNCCD][CORRECT] Record fragment file and remove pre correction notebook

Merged Karim Ahmed requested to merge feat/fragments_pnccd into feat/pnccd_calcat_interface

Remove precorrection notebook and add fragments for retrieved constants for pnCCD correction

Description

  • Remove pnCCD preocorretcion notebook
  • New function: cal_tools.tools.record_constant_details
  • Replace how fragments are added for epix100 Correction
  • Add fragments for pnCCD correction
  • Add test for cal_tools.tools.record_constant_details

How Has This Been Tested?

  • Tested against reference runs

Relevant Documents (optional)

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I added tests where appropriate.

Reviewers

@kluyvert @schmidtp

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Karim Ahmed added 1 commit

    added 1 commit

    • 32820849 - rename function to write_constants_fragment and update it based on MR discussions

    Compare with previous version

  • Karim Ahmed resolved all threads

    resolved all threads

  • Karim Ahmed added 1 commit

    added 1 commit

    • 851bc400 - avoid creating a new fragment for each karabo_da

    Compare with previous version

  • Thomas Kluyver resolved all threads

    resolved all threads

  • Karim Ahmed added 1 commit

    added 1 commit

    • 6a66dc74 - use jf metadata instead of pnccd for testing

    Compare with previous version

  • Author Owner

    Thank you @kluyvert for the review.

    Note: I have replaced pnccd metadata with Jungfrau in the test. To have a test with multiple modules.

  • Karim Ahmed changed title from [PNCCD][CORRECT] Record fragment to [PNCCD][CORRECT] Record fragment file and remove pre correction notebook

    changed title from [PNCCD][CORRECT] Record fragment to [PNCCD][CORRECT] Record fragment file and remove pre correction notebook

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading