[PNCCD][CORRECT] Record fragment file and remove pre correction notebook
Remove precorrection notebook and add fragments for retrieved constants for pnCCD correction
Description
- Remove pnCCD preocorretcion notebook
- New function:
cal_tools.tools.record_constant_details
- Replace how fragments are added for epix100 Correction
- Add fragments for pnCCD correction
- Add test for
cal_tools.tools.record_constant_details
How Has This Been Tested?
- Tested against reference runs
Relevant Documents (optional)
Types of changes
- New feature (non-breaking change which adds functionality)
Checklist:
- I added tests where appropriate.
Reviewers
Edited by Karim Ahmed
Merge request reports
Activity
Filter activity
added Testing Waiting for review labels
assigned to @ahmedk
removed Testing label
added 1 commit
- 180c3eb2 - add and use record_constant_details and remove precorrect for pnccd
- Resolved by Karim Ahmed
- Resolved by Karim Ahmed
- Resolved by Karim Ahmed
- Resolved by Karim Ahmed
added 1 commit
- 32820849 - rename function to write_constants_fragment and update it based on MR discussions
- Resolved by Karim Ahmed
- Resolved by Thomas Kluyver
added 1 commit
- 851bc400 - avoid creating a new fragment for each karabo_da
added 1 commit
- 6a66dc74 - use jf metadata instead of pnccd for testing
Thank you @kluyvert for the review.
Note: I have replaced pnccd metadata with Jungfrau in the test. To have a test with multiple modules.
Please register or sign in to reply