[EPIX100][CORRECT] Avoid including histogram calculator with empty array
While investigating failed runs on https://redmine.xfel.eu/issues/151837. Run 49 for epix100 was found in a failed state.
Checking the report. The error is related to plotting values in histogram calculators.
Description
As histCalGainCorSingles
was never filled because there was no single photons events for any train d_sing
. The array was None and pyDetLib failed while attempting to get its .size()
I have avoided adding a histogram calculator to plotting in the first place if the corresponding array is empty.
How Has This Been Tested?
Running the same run interactively
Relevant Documents (optional)
Types of changes
- Bug fix (non-breaking change which fixes an issue)
Checklist:
Reviewers
Merge request reports
Activity
changed milestone to %3.10.0
assigned to @ahmedk
This LGTM.
I have a MR (!825 (merged)) that replaces
xcal.HistogramCalculator
bynp.histogram
for histogram calculation, as imho the former adds a level complexity without bringing any relevant advantages.I will do a new commit on it with a similar fix, since the current version also fails for this run due to the same issue.
Thank you @duarten , Yes This is true. I look forward to merging your change as well. It is good we are moving from these calculators.
mentioned in merge request !825 (merged)
added Waiting for review label
mentioned in commit 4cba96fc