Use status AW in myMdC if correction failed for some detectors in a run
2 unresolved threads
2 unresolved threads
Description
We want to provide a clearer status when there are multiple detectors in a run and correction has failed for some but not all of them. The status 'AW' means 'available with warning'.
While trying to test this, I also noticed a problem with my recent changes to how we detect jobs are finished: we were checking the abbreviated Slurm state (e.g. CD
) against the names of full states (COMPLETED
), so I've tried to make this consistent. I can split this out if needed
How Has This Been Tested?
Deployed on max-exfl017, tried with myMdC test instance with p900113, r9981.
Relevant Documents (optional)
Types of changes
- Bug fix (arguably)
Checklist:
- My code follows the code style of this project.
Reviewers
Merge request reports
Activity
Filter activity
179 183 if str(r['job_id']) in statii: 180 184 # statii contains jobs which are still going (from squeue) 181 185 slstatus, runtime = statii[str(r['job_id'])] 182 execn_ongoing_jobs.append(f"{slstatus}-{runtime}") 183 184 186 else: 185 187 # These jobs have finished (successfully or otherwise) 186 188 _, runtime, slstatus = slurm_job_status(r['job_id']) 187 189 188 190 finished = slstatus in STATES_FINISHED 191 if not finished: 192 short_state = STATE_ABBREVS.get(slstatus, slstatus) mentioned in commit 3321be93
changed milestone to %3.11.0
Please register or sign in to reply