[LPD1M][Dark] Return None data for modules with 0 trains to skip processing

Review changes
Download
Patches
Plain diff

Merged [LPD1M][Dark] Return None data for modules with 0 trains to skip processing

fix/avoid_errors_for_empty_modules into fix/lpd-dark-daemon-children

Overview 2
Commits 1
Pipelines 0
Changes 1

Merged Karim Ahmed requested to merge fix/avoid_errors_for_empty_modules into fix/lpd-dark-daemon-children 1 year ago

Overview 2
Commits 1
Pipelines 0
Changes 1

Description

With the latest release, an unintentional change of behavior was introduced. For modules was no data instead of skipping the processing and the plots with 3.11 an expectation is raised.

I have altered the condition only to raise an exception for modules with data less than the minimum number of trains and go on expecting the skip to happen for modules with 0 trains to process.

How Has This Been Tested?

Tested locally, is being tested with unitests now, and hotfixed in production

Relevant Documents (optional)

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@kluyvert @schmidtp

Edited 1 year ago by Karim Ahmed

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

Request review from

Labels

None

Select labels

Manage project labels

Milestone

None

Time tracking

No estimate or time spent

0 Participants

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.