Skip to content
Snippets Groups Projects

move some logs to DEBUG and extend the report sleep

Merged move some logs to DEBUG and extend the report sleep
feat/test_logs into master
1 unresolved thread
Merged Karim Ahmed requested to merge feat/test_logs into master
1 unresolved thread

Description

Move some logs from info to debug and leave the info logs exclusive for successful test info.

How Has This Been Tested?

  • Unit tests

Relevant Documents (optional)

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

Reviewers

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
tests/test_reference_runs/test_pre_deployment.py
483 482 # confirm that all jobs succeeded.
484 483 assert errors == 0
485 484
485 time_to_wait = 5
486 time_counter = 0
486 487 # 2nd check for report availability.
487 488 report_file = out_folder / f"{report_name}.pdf"
488 assert report_file.exists(), f"{test_key} failure, report doesn't exists."
489 while not report_file.exists():
490 time.sleep(1)
491 time_counter += 1
  • Comment on lines +489 to +491
    Thomas Kluyver
    Thomas Kluyver @kluyvert ·
    Owner

    If slurm_watcher has already waited for all jobs to finish, shouldn't the report already exist? Or can it be delayed in showing up on the filesystem?

  • Karim Ahmed
    Karim Ahmed @ahmedk ·
    Author Owner

    Yes, I think so, and even with the previous sleep sometime it reports that that there is no report even though when I check I can find an available report. So I thought of increasing the timeout in that way.

  • Thomas Kluyver
    Thomas Kluyver @kluyvert ·
    Owner

    Fair enough. In that case it LGTM.

  • Please register or sign in to reply
  • Karim Ahmed resolved all threads

    resolved all threads

  • Karim Ahmed marked this merge request as ready

    marked this merge request as ready

  • Karim Ahmed changed the description

    changed the description

  • Karim Ahmed removed Doing label

    removed Doing label

  • Karim Ahmed
    Karim Ahmed @ahmedk ·
    Author Owner

    Thank you @kluyvert

  • Karim Ahmed merged

    merged

  • Karim Ahmed mentioned in commit a5fcf4dd

    mentioned in commit a5fcf4dd

  • Karim Ahmed changed milestone to %3.11.2

    changed milestone to %3.11.2

  • Karim Ahmed changed milestone to %3.11.3

    changed milestone to %3.11.3

    • Please register or sign in to reply

    Legal Notice | Contacts