Skip to content
Snippets Groups Projects

[JUNGFRAU][Correct]][Dark] Fix manual edit for operating conditions

Merged Karim Ahmed requested to merge fix/manual_edit_conditions into master
All threads resolved!

Description

This MR is related to this ticket: https://redmine.xfel.eu/issues/161355 There was a need to overwrite the gain mode value for Jungfrau through proposal configurations.

This was not possible easily as the manual edit is different for Jungfrau notebooks because all conditions need to be manually edited because they are conditioned by only one flag, unlike other detector notebooks.

This MR separates every operating condition with its own flag. It uses -1 as a default value for the parameter to read it from files.

How Has This Been Tested?

  • TBD using CI tests

Relevant Documents (optional)

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

Reviewers

@schmidtp

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Yes, this is exactly what I meant :heart:

    LGTM beside minor comment and pending testing.

  • Karim Ahmed added 1 commit

    added 1 commit

    • 96abfe32 - explicitly display if a parameter was manually set

    Compare with previous version

  • Karim Ahmed changed milestone to %3.11.3

    changed milestone to %3.11.3

  • Karim Ahmed resolved all threads

    resolved all threads

  • merged

  • Karim Ahmed mentioned in commit 6b696b69

    mentioned in commit 6b696b69

  • Please register or sign in to reply
    Loading