[JUNGFRAU][Correct]][Dark] Fix manual edit for operating conditions

Review changes
Download
Patches
Plain diff

Merged [JUNGFRAU][Correct]][Dark] Fix manual edit for operating conditions

Overview 3
Commits 2
Pipelines 0
Changes 2

Merged Karim Ahmed requested to merge fix/manual_edit_conditions into master 1 year ago

Overview 3
Commits 2
Pipelines 0
Changes 2

Description

This MR is related to this ticket: https://redmine.xfel.eu/issues/161355 There was a need to overwrite the gain mode value for Jungfrau through proposal configurations.

This was not possible easily as the manual edit is different for Jungfrau notebooks because all conditions need to be manually edited because they are conditioned by only one flag, unlike other detector notebooks.

This MR separates every operating condition with its own flag. It uses -1 as a default value for the parameter to read it from files.

How Has This Been Tested?

TBD using CI tests

Relevant Documents (optional)

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

Update calibration_configurations: https://git.xfel.eu/detectors/calibration_configurations/-/merge_requests/27

Reviewers

@schmidtp

Edited 1 year ago by Karim Ahmed

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

Assignee

Karim Ahmed

Select assignees

0 Reviewers

None

Request review from

Labels

None

Select labels

Manage project labels

Milestone

3.11.3

None

Time tracking

No estimate or time spent

2 Participants

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.