Skip to content
Snippets Groups Projects

[AGIPD][Dark] Add timings

Merged Karim Ahmed requested to merge fix/add_timings_AGIPD into master
1 unresolved thread

Description

In this redmine ticket it was realized that AGIPD dark processing lacks timings for different cells. This MR addresses this issue by adding timings for the AGIPD dark notebook as well as the overall summary notebook.

How Has This Been Tested?

  • TBD using unit tests.

Relevant Documents (optional)

agipd_timings.pdf

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@tmichela @kluyvert

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
327 331 "metadata": {},
328 332 "outputs": [],
329 333 "source": [
334 "step_timer.start()\n",
  • It shouldn't be necessasry to call .start() again right after .done_step() - each new call to .done_step() is timed since the last step.

    There's also no harm in calling .start() again, though.

  • Please register or sign in to reply
  • Thomas Kluyver
  • Thanks! I had been thinking about a more sweeping approach of timing every cell using Princess, but on reflection I prefer this approach - it's more work up front, but it will be easier to make sense of the resulting information when we want to know what's slow.

  • Karim Ahmed added 1 commit

    added 1 commit

    • 7b3a148b - improve timing message based on MR suggestion and record timing for async constant retrieval

    Compare with previous version

  • Author Owner

    Thank you for the review!

  • merged

  • Karim Ahmed mentioned in commit 91b39e32

    mentioned in commit 91b39e32

  • Philipp Schmidt changed milestone to %3.11.4

    changed milestone to %3.11.4

  • Please register or sign in to reply
    Loading