[Tests] Validate metadata for retrieved constants before validating the corrected files

Description

This MR addresses: https://git.xfel.eu/calibration/pycalibration/-/issues/89

In case the retrieved constants are different, the tests should realize this before validating the corrected files. This help in understanding the reason for the test failure instead of spending time investigating why the files were not validated and have different values.

How Has This Been Tested?

• Tested locally after changing parameters of one test to get the wrong Calibration constants.
• CI-InProgress

Relevant Documents (optional)

Types of changes

• Test (additional or refactored tests)

Checklist:

Reviewers

@kluyvert @schmidtp

assigned to @ahmedk

added 1 commit

• d005d9e7 - apply test only for correct calibrations

Compare with previous version

added 1 commit

• d269d58c - fix after testing with an expected failing test

Compare with previous version

marked this merge request as ready

changed the description

added Waiting for review label

added 1 commit

• e3e8b6d9 - use deepDiff to find difference in dictionaries

Compare with previous version

added 1 commit

• 8f5d9a28 - use deepDiff to find difference in dictionaries

Compare with previous version

added 1 commit

• a74c5a95 - use deepDiff to find difference in dictionaries

Compare with previous version

Thanks, that diff output looks reasonable for giving us a sense of what has changed. Assuming the slow tests pass, this LGTM.

Thanks, LGTM!

TIL deepdiff

Comments from the tests:

1- DSSC doesn't have retrieved-constants stored in the calibration metadata.

2- Correction for one of the ePix100 tests failed because previously we retrieved specific dark constants, however now we retrieved all dark constants and use only what we need in correction. This led to a test failure because badPixels was unavailable in the YAML file.

• For this, I will update the reference folder for HED_IA1_EPX100-1-CORRECT test.

3- Jungfrau and pnCCD didn't have retrieved-constants stored before in for the reference folder. I will also update the calibration metadata for all of the reference data for the correction of both detectors

Updated the calibration metadata for correction reference runs for Jungfrau, ePix100, and pnCCD

added 1 commit

• 8cf458cc - remove automated_test key for setup and don't assume availability of...

Compare with previous version

resolved all threads

Thank you for the review!

merged

mentioned in commit f1255265

changed milestone to %3.12.0