[Webservice] Create correction reports in MyMdC when jobs have finished
Description
MyMdC now has space for reports associated with each run (planning#185). This is meant to be used for reports from corrections. So now we need to add the details when an execution has finished and a PDF report created.
Closes planning#189
How Has This Been Tested?
Deployed under xcaltst and recalibrated a CALLAB run: https://exflmdtest.desy.de/test_metadata/proposals/259/runs/91672#run-reports
Types of changes
- New feature (non-breaking change which adds functionality)
Checklist:
- My code follows the code style of this project.
Reviewers
Merge request reports
Activity
- Resolved by Thomas Kluyver
- Resolved by Thomas Kluyver
- Resolved by Thomas Kluyver
- Resolved by Thomas Kluyver
Seeing how straightforward this process is based on the job database, what do you think about performing it for (at least) the current database?
changed milestone to %3.12.0
mentioned in merge request !884 (merged)
I'll hold off on this until we've got !884 (merged) sorted. It doesn't matter for new runs, but if we want to apply both changes to previous runs, we need to coordinate, otherwise we'll end up recording the wrong paths.
added 1 commit
- b8b78387 - Expand run folder to 4 digits in report backfill script
changed milestone to %3.12.1
Given the verification to rename legacy folders is starting to hold things back:
- Assuming we merge !884 (merged) and this, any correction jobs going forward will use the new numbering scheme and are inserted into myMdC
- Nothing existing or new will visibly break, but we cannot (or don't want to) run the insertion script for legacy jobs
- We may end up with two folders for the same run, but the migration script fixes that
Edited by Philipp SchmidtAssuming we merge !884 (merged) and this, any correction jobs going forward will use the new numbering scheme and are inserted into myMdC
That's right.
Nothing existing or new will visibly break, but we cannot (or don't want to) run the insertion script for legacy jobs
We can run the insertion script, but if we're also renaming the existing report folders, we want to do that before inserting reports. The insertion script can then find the renamed folders. Whether we want to do that is your call, but it should be feasible if you want.