Skip to content
Snippets Groups Projects

[Webservice] Create correction reports in MyMdC when jobs have finished

Merged Thomas Kluyver requested to merge mymdc-correction-reports into master

Description

MyMdC now has space for reports associated with each run (planning#185). This is meant to be used for reports from corrections. So now we need to add the details when an execution has finished and a PDF report created.

Closes planning#189

How Has This Been Tested?

Deployed under xcaltst and recalibrated a CALLAB run: https://exflmdtest.desy.de/test_metadata/proposals/259/runs/91672#run-reports

image

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.

Reviewers

@schmidtp @maial

Edited by Thomas Kluyver

Merge request reports

Checking pipeline status.

Merged by Karim AhmedKarim Ahmed 1 year ago (Jan 18, 2024 10:44am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thomas Kluyver
  • Thomas Kluyver changed the description

    changed the description

  • Philipp Schmidt changed milestone to %3.12.0

    changed milestone to %3.12.0

  • Thomas Kluyver added 2 commits

    added 2 commits

    • 7f6c5261 - Change warning logs to errors
    • 56bac4c9 - Use request time instead of file mtime for cal_report_at

    Compare with previous version

  • Thomas Kluyver added 1 commit

    added 1 commit

    • fe384bb8 - Add script to backfill reports

    Compare with previous version

  • Thomas Kluyver added 1 commit

    added 1 commit

    • 4a685f27 - Minor fixes to backfill script

    Compare with previous version

  • Philipp Schmidt mentioned in merge request !884 (merged)

    mentioned in merge request !884 (merged)

  • Thank you for the speedy MR, LGTM.

  • Thomas Kluyver resolved all threads

    resolved all threads

  • I'll hold off on this until we've got !884 (merged) sorted. It doesn't matter for new runs, but if we want to apply both changes to previous runs, we need to coordinate, otherwise we'll end up recording the wrong paths.

  • Thomas Kluyver added 1 commit

    added 1 commit

    • b8b78387 - Expand run folder to 4 digits in report backfill script

    Compare with previous version

  • Karim Ahmed changed milestone to %3.12.1

    changed milestone to %3.12.1

  • Given the verification to rename legacy folders is starting to hold things back:

    • Assuming we merge !884 (merged) and this, any correction jobs going forward will use the new numbering scheme and are inserted into myMdC
    • Nothing existing or new will visibly break, but we cannot (or don't want to) run the insertion script for legacy jobs
    • We may end up with two folders for the same run, but the migration script fixes that

    Is this correct? @kluyvert @ahmedk

    Edited by Philipp Schmidt
  • Assuming we merge !884 (merged) and this, any correction jobs going forward will use the new numbering scheme and are inserted into myMdC

    That's right.

    Nothing existing or new will visibly break, but we cannot (or don't want to) run the insertion script for legacy jobs

    We can run the insertion script, but if we're also renaming the existing report folders, we want to do that before inserting reports. The insertion script can then find the renamed folders. Whether we want to do that is your call, but it should be feasible if you want.

  • Merging to deploy this now

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading