Skip to content

[GOTTHARD2][Correct][Dark] Break assumptions on receiver names

Karim Ahmed requested to merge fix/flexible_receiver_names into master

Description

After having the opportunity to look at data for the HIREX at proposal p900384 It was realized that receiver names are not called based on the assumptions from the DETLAB data and the usual GH2 receiver names. RECEIVER or RECEIVER{1 or 2}

The new receivers for GH2 25um are called GOTTHARD2_MASTER and GOTTHARD2_SLAVE. This MR removes these assumptions by adding a new parameter which is the receiver suffix

For correction, I did the same and added another parameter to be able to name the receiver in the correction device other than the GOTTHARD2_MASTER name when correcting a run for a HIREX detector.

How Has This Been Tested?

corr_gh2_50um.pdf

dark_gh2_50um.pdf

dark_gh2_25um.pdf

corr_gh2_25um.pdf

Dark is tested in production.

gh2_dark_hirex_production.pdf

gh2_dark_scs50um_production.pdf

Relevant Documents (optional)

default.yaml

Screenshot_from_2024-01-18_07-44-31

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@schmidtp @kluyvert

Edited by Karim Ahmed

Merge request reports