Skip to content
Snippets Groups Projects

[GOTTHARD2][Correct][Dark] Break assumptions on receiver names

Merged Karim Ahmed requested to merge fix/flexible_receiver_names into master
2 unresolved threads

Description

After having the opportunity to look at data for the HIREX at proposal p900384 It was realized that receiver names are not called based on the assumptions from the DETLAB data and the usual GH2 receiver names. RECEIVER or RECEIVER{1 or 2}

The new receivers for GH2 25um are called GOTTHARD2_MASTER and GOTTHARD2_SLAVE. This MR removes these assumptions by adding a new parameter which is the receiver suffix

For correction, I did the same and added another parameter to be able to name the receiver in the correction device other than the GOTTHARD2_MASTER name when correcting a run for a HIREX detector.

How Has This Been Tested?

corr_gh2_50um.pdf

dark_gh2_50um.pdf

dark_gh2_25um.pdf

corr_gh2_25um.pdf

Dark is tested in production.

gh2_dark_hirex_production.pdf

gh2_dark_scs50um_production.pdf

Relevant Documents (optional)

default.yaml

Screenshot_from_2024-01-18_07-44-31

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@schmidtp @kluyvert

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
244 247 " n_trains = img_key_data.shape[0]\n",
245 248 " all_trains = len(img_key_data.train_ids)\n",
246 249 " print(\n",
247 " f\"{receiver} has {all_trains - n_trains} \"\n",
250 " f\"{src} for run {run} has {all_trains - n_trains}\"\n",
  • Karim Ahmed
    Karim Ahmed @ahmedk started a thread on the diff
  • 405 412 "\n",
    406 413 " out_file = out_folder / raw_file.name.replace(\"RAW\", \"CORR\")\n",
    407 414 " # Select module INSTRUMENT sources and deselect empty trains.\n",
    408 " dc = H5File(raw_file).select(receivers, require_all=True)\n",
    415 " dc = H5File(raw_file).select(data_sources, require_all=True)\n",
  • Karim Ahmed changed the description

    changed the description

  • Karim Ahmed added 1 commit

    added 1 commit

    • 6687e001 - rename corr_data_source to corr_source_template

    Compare with previous version

  • Karim Ahmed enabled an automatic merge when the pipeline for 6687e001 succeeds

    enabled an automatic merge when the pipeline for 6687e001 succeeds

  • Karim Ahmed canceled the automatic merge

    canceled the automatic merge

  • merged

  • Karim Ahmed mentioned in commit 29398da2

    mentioned in commit 29398da2

  • Karim Ahmed mentioned in merge request !955 (merged)

    mentioned in merge request !955 (merged)

  • Please register or sign in to reply
    Loading