Skip to content
Snippets Groups Projects

[Gotthard2][Correct] Add `idx` to `da_to_pdu` to use in picking correct `data_source`

Merged Karim Ahmed requested to merge fix/fix_workaround_to_pick_correct_data_source into master
All threads resolved!

Description

This is a proper fix for picking the correct data source for GH2 25um modules.

This is to avoid the developed temporary workaround. !955 (merged)

How Has This Been Tested?

Relevant Documents (optional)

hirex_gh2_correct.pdf

hirex_gh2_dark.pdf

fxe_gh2_correct.pdf

fxe_gh2_dark.pdf

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@schmidtp @kluyvert

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Other than that, LGTM

  • Karim Ahmed changed the description

    changed the description

  • Karim Ahmed resolved all threads

    resolved all threads

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • Author Owner

    Thank you @kluyvert for the review

  • merged

  • Karim Ahmed mentioned in commit 35eef5e7

    mentioned in commit 35eef5e7

  • Karim Ahmed changed milestone to %3.12.3

    changed milestone to %3.12.3

  • Karim Ahmed removed milestone %3.12.3

    removed milestone %3.12.3

  • Karim Ahmed changed milestone to %3.13.0

    changed milestone to %3.13.0

  • Please register or sign in to reply
    Loading