Skip to content
Snippets Groups Projects

[AGIPD][Correct] Some plots improvements for AGIPD offline correction

Merged Karim Ahmed requested to merge fix/improve_agipd_corr_scale_plots into master

Description

  • Remove jet colormap and leave the viridis default color map to be used.
  • overuse np.percentile to pick the right scale instead of the hard-coded numbers which shouldn't fit every corrected data.
  • Removed 3d plots after a discussion with Jola. It's duplication info already plotted in 2d and it is not very useful

How Has This Been Tested?

  • Unit tests
  • Validated results with Jola
  • Investigated plots multiple times for multiple runs.

Relevant Documents (optional)

These are some reports before and after the changes:

hed_run456_prod.pdf hed_run456_branch.pdf

hed_raw_r456_prod hed_raw_r456_branch

mid_r56_prod.pdf mid_r56_branch.pdf

mid_r56_prod mid_r56_branch

mid_run68_prod.pdf mid_r68_branch.pdf

baseline_shift_illuminated_prod baseline_shift_illuminated_branch

spb_correct_master.pdf spb_correct_branch.pdf

hed_corr_master.pdf hed__corr_branch.pdf

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@schmidtp @kluyvert

Edited by Karim Ahmed

Merge request reports

Checking pipeline status.

Merged by Karim AhmedKarim Ahmed 1 year ago (Feb 14, 2024 9:58am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading