Skip to content
Snippets Groups Projects

[Gotthard2][Correct] Store mask data properly for gotthard2 25um

Merged Karim Ahmed requested to merge fix/store_mask_gh2_25um into master
All threads resolved!

Description

@mramilli reported a bug in the offline correction where the mask is stored with the wrong number of stripes.

Screenshot_from_2024-02-07_16-45-47

It seems I made the mistake of forgetting about storing the mask after interleaving in the same way it is done for the data and gain.

This fix has a high priority as it needs to be available for the users by next week.

How Has This Been Tested?

  • HOTFIXED in production

Relevant Documents (optional)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@hammerd @schmidtp

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • LGTM

    (Feel free to merge irrespective of the performance question)

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    • 748f4c2a - Small refactors and last piece of fix after testing for storing the right mask array

    Compare with previous version

  • Karim Ahmed changed the description

    changed the description

  • Karim Ahmed resolved all threads

    resolved all threads

  • merged

  • Karim Ahmed mentioned in commit a722d718

    mentioned in commit a722d718

  • Please register or sign in to reply
    Loading