Skip to content
Snippets Groups Projects

Frame filtering by candidate list

Open Egor Sobolev requested to merge feat/candidate-list into feat/legacy

This implements the frame filtering by the candidate list with formats that we discussed: h5, csv. In both formats we expect three datasets: trainId, pulseId, classId, which can be given under any name (parameter). The third options is EXDF format, which also can be read as h5 but it is read here with extra-data and due to that can be split on sequence files

@schmidtp @kluyvert @turkot

Merge request reports

Ready to merge by members who can write to the target branch.
  • The source branch is 1 commit behind the target branch.
  • 8 commits and 1 merge commit will be added to feat/legacy.
  • Source branch will be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Oleksii Turkot
  • I'll leave the details to Oleksii, but looks really nice overall. Thanks!

  • Very nice implementation indeed, and all my comments except the first one are very minor. I'll run the manual tests now and afterwards should be good to merge.

  • assigned to @esobolev

  • Oleksii Turkot requested review from @turkot

    requested review from @turkot

  • Egor Sobolev added 1 commit

    added 1 commit

    Compare with previous version

  • Egor Sobolev added 1 commit

    added 1 commit

    • 0b00336c - Add option to choose which frame classes to drop

    Compare with previous version

  • Egor Sobolev added 6 commits

    added 6 commits

    • 2019d066 - 1 commit from branch feat/legacy
    • 489661ee - Add reduction of frames by candidate list
    • 515d1d73 - Support csv format, isolate file reading
    • 5eea8ab0 - Fix pulse alignment
    • 5b268025 - Apply suggestions
    • 1fb1e9d8 - Add option to choose which frame classes to drop

    Compare with previous version

  • Oleksii Turkot added 1 commit

    added 1 commit

    • d2e0a17f - Allow --framelist-train-id-key and --framelist-pulse-id-key to be optional...

    Compare with previous version

    • Resolved by Oleksii Turkot

      Hi Egor, with !26 (d2e0a17f) I would like to suggest to make --framelist-train-id-key and --framelist-pulse-id-key parameters optional also for h5 and csv file inputs. Please let me know and feel free to discard or modify this commit in case you don't like the idea.

  • Egor Sobolev
  • Oleksii Turkot added 1 commit

    added 1 commit

    • f9203a0e - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Egor Sobolev resolved all threads

    resolved all threads

  • Egor Sobolev added 1 commit

    added 1 commit

    • f0121cdf - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading