Project 'detectors/pycalibration' was moved to 'calibration/pycalibration'. Please update any links and bookmarks that may still have the old path.
[AGIPD] [CORRECT] `keep_dims` if only one cellId is corrected
All threads resolved!
All threads resolved!
This fixes the issue from this ticket https://redmine.xfel.eu/issues/143284
Description
This was an old MR to solve correcting 1 cellId for AGIPD: /gpfs/exfel/exp/MID/202230/p900249/usr/Reports/r198/MID_DET_AGIPD1M-1_correct_900249_r198_220308_223408.pdf
- EXtra_data creates arrays without the cell dimension. Use
keep_dims
- Remove temporary workaround.
- This fixes a bug faced when
use_litframe_finder
is on. As the cell_sel is switched from the expectedCellRange
toLitFrameSelection
: /gpfs/exfel/exp/MID/202231/p900310/usr/Reports/r400/MID_DET_AGIPD1M-1_correct_900310_r400_221111_011350.pdf
How Has This Been Tested?
Reference runs and processing run 198 with 1 cellId as
Relevant Documents (optional)
Types of changes
- Bug fix (non-breaking change which fixes an issue)
Checklist:
Reviewers
Edited by Karim Ahmed
Merge request reports
Activity
Filter activity
- Resolved by Karim Ahmed
- Resolved by Karim Ahmed
- Resolved by Karim Ahmed
- Resolved by Karim Ahmed
changed milestone to %3.5.1
- Resolved by Karim Ahmed
As mentioned in the other MR, this is pending the EXtra-data PR. I'd also like to avoid going to 1.10, so we'll need an 1.9.x backport.
added Waiting for review label
mentioned in merge request !642 (merged)
removed milestone %3.5.1
added 551 commits
-
3de9bf3b...7b538f32 - 550 commits from branch
master
- 4ef1499b - fix plots based on selected cellIds
-
3de9bf3b...7b538f32 - 550 commits from branch
- Resolved by Karim Ahmed
Uhm, nice necro... is this related to https://redmine.xfel.eu/issues/143285?
- Resolved by Karim Ahmed
added 1 commit
- 6771c5b8 - comment on the need for a first full trainId and remove iter
Thank you @schmidtp for the review
mentioned in commit 4c881a11
Please register or sign in to reply