Skip to content
Snippets Groups Projects

[AGIPD] [CORRECT] `keep_dims` if only one cellId is corrected

Merged Karim Ahmed requested to merge fix/correct_agipd_one_cellId into master
All threads resolved!

This fixes the issue from this ticket https://redmine.xfel.eu/issues/143284

Description

This was an old MR to solve correcting 1 cellId for AGIPD: /gpfs/exfel/exp/MID/202230/p900249/usr/Reports/r198/MID_DET_AGIPD1M-1_correct_900249_r198_220308_223408.pdf

  1. EXtra_data creates arrays without the cell dimension. Use keep_dims
  2. Remove temporary workaround.
  3. This fixes a bug faced when use_litframe_finder is on. As the cell_sel is switched from the expected CellRange to LitFrameSelection: /gpfs/exfel/exp/MID/202231/p900310/usr/Reports/r400/MID_DET_AGIPD1M-1_correct_900310_r400_221111_011350.pdf

How Has This Been Tested?

Reference runs and processing run 198 with 1 cellId as

Relevant Documents (optional)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@schmidtp @roscar @kluyvert

Edited by Karim Ahmed

Merge request reports

Checking pipeline status.

Merged by Karim AhmedKarim Ahmed 2 years ago (Nov 15, 2022 8:58am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Karim Ahmed
  • Karim Ahmed
  • Karim Ahmed added 1 commit

    added 1 commit

    • 3de9bf3b - fix plots based on selected cellIds

    Compare with previous version

  • Karim Ahmed
  • Karim Ahmed changed milestone to %3.5.1

    changed milestone to %3.5.1

  • Karim Ahmed mentioned in merge request !642 (merged)

    mentioned in merge request !642 (merged)

  • Karim Ahmed added 1 deleted label

    added 1 deleted label

  • Karim Ahmed removed milestone %3.5.1

    removed milestone %3.5.1

  • Karim Ahmed added 551 commits

    added 551 commits

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    • 25b040c8 - fix plots based on selected cellIds

    Compare with previous version

  • Karim Ahmed removed 1 deleted label

    removed 1 deleted label

  • Karim Ahmed added 1 commit

    added 1 commit

    • d784162e - remove workaround for keeping dims

    Compare with previous version

  • Karim Ahmed changed the description

    changed the description

  • Karim Ahmed resolved all threads

    resolved all threads

  • Karim Ahmed changed title from [AGIPD] [CORRECT] Fix plots based on selected cellIds to [AGIPD] [CORRECT] {+keep_dims if only one cellId is corrected+}

    changed title from [AGIPD] [CORRECT] Fix plots based on selected cellIds to [AGIPD] [CORRECT] {+keep_dims if only one cellId is corrected+}

  • Karim Ahmed changed the description

    changed the description

  • Karim Ahmed added 1 commit

    added 1 commit

    • 6771c5b8 - comment on the need for a first full trainId and remove iter

    Compare with previous version

  • Karim Ahmed resolved all threads

    resolved all threads

  • Thanks, LGTM.

  • Thank you @schmidtp for the review

  • merged

  • Karim Ahmed mentioned in commit 4c881a11

    mentioned in commit 4c881a11

  • Please register or sign in to reply
    Loading