Skip to content

[AGIPD][CORRECT] Workaround for fixing plots after correcting one cellId

Karim Ahmed requested to merge fix/correct_one_cellId_workaround into master

A workaround for https://git.xfel.eu/detectors/pycalibration/-/merge_requests/640. Based on EXtra-data 1.9.1

The workaround is planned to be used until we can safely switch to EXtra-data > 1.10.0

Description

  • Producing 1 cellId corrected images leads to multiple errors:
  1. When one cellId is selected for correction. Add a new axis for the cellId for corrected sources to preserve expected dimension. This is the workaround.
  2. The histogram pulseId intensity plots fails as there is only on pulseId value. adapt pulse_range if corrected cellId is one.
  3. cell_id_preview is set to 1 and it was discovered to be used as a cell_id_preview. properly show and index cell_id_preview
  • During debugging it was found that the mean RAW image is always created from all cells. It should be only created from the selected cellIds to correct.

How Has This Been Tested?

one_cellId_AGIPD_MID.pdf

Relevant Documents (optional)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@calibration

Edited by Karim Ahmed

Merge request reports