[AGIPD][CORRECT] Workaround for fixing plots after correcting one cellId

A workaround for https://git.xfel.eu/detectors/pycalibration/-/merge_requests/640. Based on EXtra-data 1.9.1

The workaround is planned to be used until we can safely switch to EXtra-data > 1.10.0

Description

• Producing 1 cellId corrected images leads to multiple errors:

1. When one cellId is selected for correction. Add a new axis for the cellId for corrected sources to preserve expected dimension. This is the workaround.
2. The histogram pulseId intensity plots fails as there is only on pulseId value. adapt pulse_range if corrected cellId is one.
3. cell_id_preview is set to 1 and it was discovered to be used as a cell_id_preview. properly show and index cell_id_preview

• During debugging it was found that the mean RAW image is always created from all cells. It should be only created from the selected cellIds to correct.

How Has This Been Tested?

one_cellId_AGIPD_MID.pdf

Relevant Documents (optional)

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@calibration

added 1 commit

• 183129e4 - Workaround for fixing plots after correcting one cellId

Compare with previous version

changed milestone to %3.5.1

added Waiting for review label

changed title from Workaround for fixing plots after correcting one cellId to [AGIPD][CORRECT] Workaround for fixing plots after correcting one cellId

changed the description

added 1 commit

• 77584b7d - Workaround for fixing plots after correcting one cellId

Compare with previous version

added 1 commit

• 3ee2f64d - Workaround for fixing plots after correcting one cellId

Compare with previous version

changed the description

Thanks! Only some small nitpicks and LGTM otherwise.

We should skip EXtra-data 1.10 entirely and do a dedicated testing run for 1.11 (released just now). This is of course pending the usage of DataCollection.files.

yes, I added >1.10.0 as I didnt remember which release we are going to use later.

As I understood we are not planning to use 1.11 for the next release 3.5.1.

Shall I already test our notebooks with 1.11?

I'd say we have enough MRs to check for 3.5.1 to postpone that for now, let's focus on that afterwards.

LGTM

added 1 commit

• 6e9341e6 - MR suggestion

Compare with previous version

removed Waiting for review label

Thank you for the review!

merged

mentioned in commit 5b14fc2e