DetectorAssembler: assemble with extra shape (multiple frames)
I see that EXtra-geom generally plays well with arrays having some extra dimensions up front. So by conforming to this pattern in terms of buffers, we can pretty easily enable DetectorAssembler
to assemble multi-frame images. This could be relevant for:
- Providing a full-detector, full-train, assembled output
- Has been asked for by different people at different instruments
- Pretty CPU slow (performance can definitely be improved, this is very naive)
- Very network slow (that is inherent to desire for full detector on single node)
- Providing multi-frame assembled preview in GUI
- Karabo GUI will in this case provide a cool slider
- Should obviously not try to update this at full 2 Hz for network and usability reasons
- Nevertheless, Jola would be happy to have this option for commissioning and it sort of comes for free in this case
Merge request reports
Activity
added 16 commits
-
72baa028 - 1 commit from branch
devel
- 193264ed - Adding Philipp's proposed changes to TrainMatcher for merging
- e7f96bae - Use sources list to get source order, cache buffers
- b01015c4 - Allow thread pool usage
- bbb7cee4 - Allow stacking on other axes, fix thread pool
- e1b0b8d1 - Adding option to skip Karabo channel output
- ef898211 - Adding Philipp's proposed changes to TrainMatcher for merging
- f8f380cc - Use sources list to get source order, cache buffers
- b2b5aca1 - Allow thread pool usage
- 02a4ccd9 - Allow stacking on other axes, fix thread pool
- 07b6c972 - Adding option to skip Karabo channel output
- 426d707b - Merge branch 'stacking-shmem-matcher' of...
- a79b501a - Update description of stacking patterns
- beb32df5 - Fix reconfigure bug and prevent sources from being sorted
- f97de39d - Follow extra-geom approach to extra shape
- 713d3ee3 - Merge branch 'assemble-extra-shapes' of...
Toggle commit list-
72baa028 - 1 commit from branch
added 1 commit
- d90c0b50 - Move closer to stacking version: add assembled as new source
mentioned in merge request !12 (closed)
mentioned in issue #23 (closed)
mentioned in merge request !54 (closed)
Closing this for now. The
DetectorAssembler
has changed a lot. In the modern version, multi-frame assembly would actually be simpler; in this commit, I decided to just reduce (because I'm just testing something else), but we could just exploit thexarray
bit to prepend add aframe
axis in case dimensionality calls for it.mentioned in merge request !142 (merged)