Skip to content
Snippets Groups Projects
Commit bbea7a70 authored by Thomas Kluyver's avatar Thomas Kluyver
Browse files

Merge branch 'fix/webservice-param-false' into 'master'

[Webservice] Fix passing boolean false parameters to xfel-calibrate

See merge request !1117
parents d5e2d06a 1afa36bb
No related branches found
No related tags found
1 merge request!1117[Webservice] Fix passing boolean false parameters to xfel-calibrate
......@@ -95,14 +95,14 @@ def test_parse_config():
'other_empty_key': "''",
'brian': 'scone'}
expected = ['whatever', '--somebool', '--alist', '1', '2', '3',
expected = ['whatever', '--somebool', '--no-notsomebool',
'--alist', '1', '2', '3',
'--some_empty_key', '', '--other_empty_key', '',
'--brian', 'scone']
config = parse_config(cmd, config)
assert config == expected
assert '--notsomebool' not in config
with pytest.raises(ValueError):
config = {'some key': 'value'}
......
......@@ -333,8 +333,7 @@ def parse_config(cmd: List[str], config: Dict[str, Any]) -> List[str]:
cmd.append(f"--{key}")
cmd += [str(v) for v in value]
elif isinstance(value, bool):
if value:
cmd += ["--{}".format(key)]
cmd.append(f"--{key}" if value else f"--no-{key}")
else:
if value in ['""', "''"]:
value = ""
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment