Skip to content

[Webservice] Fix passing boolean false parameters to xfel-calibrate

Thomas Kluyver requested to merge fix/webservice-param-false into master

Description

Boolean parameters with a default of True in a notebook could not be set to False by webservice config, because no CLI option was generated for false values. This would also hide typos in these parameters by silently ignoring them.

It seems that this hasn't actually come up all that often. A few REMI proposals in 2021 missed out on save-raw-triggers: false, so maybe stored extra information, but this parameter is now ignored anyway. And LPD-1M in p900320 had all 4 correction options (offset_corr, rel_gain, ff_map, gain_amp_map) disabled for some reason.

This MR simply adds the --no-foo flag which xfel-calibrate expects to turn a boolean off.

How Has This Been Tested?

TBD

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.

Reviewers

@ahmedk @schmidtp

Merge request reports