Skip to content

feat[Jungfrau][Dark]: use CalibrationData to retrieve prior CCVs

Karim Ahmed requested to merge feat/prior_ccv into master

Description

This MR update Jungfrau Darks to use CalibrationData API in retrieving prior CCV using the begin_at_strategy. This MR is related to this issue as well: https://git.xfel.eu/calibration/planning/-/issues/200

In trying to reduce the unrelated diff from the Injection of CCVs at !1022 (merged) I have moved these changes to this MR.

Changes:

  • Replace get_dir_creation_date, like the rest of the notebooks.
  • New get_full_path method
  • New begin_at_strategy argument. I am using strings. Another solution is to use enums, however, I felt it is not needed for two strings only.
  • Replace get_from_db with CalibrationData API and x.from_condition()
  • Update h5path key to dataset to match names used in CalCatAPI and CalCat
  • Add JUNGFRAUConditions from extra to calcat_interface2

Note: Later after reviewing this MR, I plan on updating extra.CalibrationData.

How Has This Been Tested?

  • Automated tests

Relevant Documents (optional)

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

Reviewers

@schmidtp @kluyvert

Edited by Karim Ahmed

Merge request reports