Skip to content
Snippets Groups Projects

[Jungfrau][Correct] fix: Skip exposure_timeout for gain constant retrieval

Merged Karim Ahmed requested to merge feat/unuse_exposure_timeout_gain_constant into master
3 unresolved threads

Description

  • Remove exposure timeout from gain constants conditions
  • use calcat_interface2

How Has This Been Tested?

  • Will test the failed run from production :
  • integration test

Relevant Documents (optional)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@schmidtp @kluyvert @mramilli

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thomas Kluyver
  • Karim Ahmed added 1 commit

    added 1 commit

    • 9e51056b - fix: display ccv table and rename force_fixed_gain_constants

    Compare with previous version

  • Karim Ahmed changed milestone to %3.15.5

    changed milestone to %3.15.5

  • Karim Ahmed marked the checklist item Will test the failed run from production as completed

    marked the checklist item Will test the failed run from production as completed

  • Karim Ahmed changed the description

    changed the description

    • Apologies for missing this earlier. We had verified that it should not apply to gain constants for now, but I failed to realize this way it would still use it for querying of course...

      I'm mildly unsettled by the large change done quickly. Shall we rebase this on top of master (if it isn't already) and run the entire test suite, or at least the affected detectors (LPD, JF, GH2)?

    • I think only JUNGFRAU is affected? The calcat_interface2 changes are in JUNGFRAUConditions. Or do you mean everything we've touched recently?

    • Yes, touched since the last deployment of the main branch.

    • Makes sense, yes. It does need rebasing, unfortunately.

    • Please register or sign in to reply
  • Karim Ahmed added 21 commits

    added 21 commits

    • 9e51056b...d6de823a - 19 commits from branch master
    • 92f842c0 - fix: Skip exposure_timeout for gain constant retrieval
    • 2ebc4a4a - fix: display ccv table and rename force_fixed_gain_constants

    Compare with previous version

  • Karim Ahmed marked the checklist item integration test as completed

    marked the checklist item integration test as completed

  • merged

  • Karim Ahmed mentioned in commit 638788ef

    mentioned in commit 638788ef

  • Please register or sign in to reply
    Loading