Refactor: Move report related part to xfel_calibrate (!215) · Merge requests · calibration / pycalibration · GitLab

Snippets Groups Projects

Merged Mikhail Karnevskiy requested to merge refactor/localize_report into master 5 years ago

All threads resolved!

Now all report related code is located at xfel_calibrate. Therefore this package stays for submitting notebooks to slurm and report generation. Moved from tools.py to finalize.py functions are untouched.

Edited 5 years ago by Mikhail Karnevskiy

Activity

Mikhail Karnevskiy changed the description 5 years ago

changed the description
Karim Ahmed @ahmedk started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Mikhail Karnevskiy
Last reply by Mikhail Karnevskiy 5 years ago

Mikhail Karnevskiy added 1 commit 5 years ago

added 1 commit

fbd256f3 - Move report related part to xfel_calibrate

Compare with previous version

Mikhail Karnevskiy resolved all discussions 5 years ago

resolved all discussions

Karim Ahmed @ahmedk · 5 years ago

Owner

LGTM but please make sure that this is tested on at least two different notebooks for two different detectors not only the tutorial one.

Mikhail Karnevskiy added 1 commit 5 years ago

added 1 commit

51b00822 - Move report related part to xfel_calibrate

Compare with previous version

Mikhail Karnevskiy merged 5 years ago

merged

Mikhail Karnevskiy mentioned in commit 5 years ago

mentioned in commit 721531f3

Please register or sign in to reply

Legal Notice | Contacts