Skip to content
Snippets Groups Projects

Pop internal disable-correct key from data mapping

Merged Philipp Schmidt requested to merge fix/disable-correct-passing into master
All threads resolved!

Description

Fixes https://in.xfel.eu/redmine/issues/119828 introduced by https://git.xfel.eu/detectors/pycalibration/-/merge_requests/611

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Reviewers

@ahmedk @roscar

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • f4623fa3 - Log any detector skipped for corrections due to config

    Compare with previous version

  • Karim Ahmed resolved all threads

    resolved all threads

  • Thank you, LGTM

  • Tested as a part of 3.5.0b2.

    2022-02-23 20:32:46,437 - root - WARNING - [webservice.py:981] WARN: nothing to calibrate in path /gpfs/exfel/exp/CALLAB/202031/p900113/raw/r9974/, please contact det-support@xfel.eu
    2022-02-23 20:32:46,437 - root - WARNING - [webservice.py:976] Skipping disabled detector FXE_DET_LPD1M-1
  • Karim Ahmed approved this merge request

    approved this merge request

  • Thanks for review and testing

  • Philipp Schmidt mentioned in commit 01278d3c

    mentioned in commit 01278d3c

  • removed milestone %3.5.0

  • Philipp Schmidt changed milestone to %3.5.0

    changed milestone to %3.5.0

  • Please register or sign in to reply
    Loading