[AGIPD][PC] Feat/skip sanitization based on the retrieved PC's variant

Skip PC sanitization if a CCV of V1 was retrieved.

Description

How Has This Been Tested?

• Validate with @jsztuk
• To be tested.

Relevant Documents (optional)

Types of changes

• New feature (non-breaking change which adds functionality)

Checklist:

Reviewers

added 11 commits

• dcf6e7fd...ce4b0607 - 10 commits from branch master
• 5a6dea09 - skip PC sanitization with constants of v1

Compare with previous version

added 11 commits

• dcf6e7fd...ce4b0607 - 10 commits from branch master
• 5a6dea09 - skip PC sanitization with constants of v1

Compare with previous version

changed title from [AGIPD][PC] Feat/skip sanitization based on variant pc to [AGIPD][PC] Feat/skip sanitization based on the retrieved PC's variant

Interesting, I did not realize the most expensive step (median calculation) is needed after the sanitization step as well, so we cannot skip it.

We should include those medians in the constant. I don't understand why we need to apply math to constant data at runtime?

marked this merge request as draft

added In Progress label

added 1 commit

• 904e8983 - intercepts median for V0 and slopes median for blc_stripes

Compare with previous version

marked the checklist item Validate with @jsztuk as completed

added 1 commit

• a60f1f78 - split blc_strips and md_additional_offset definitions when selected

Compare with previous version

added 1 commit

• 7c8dbef9 - split blc_strips and md_additional_offset definitions when selected

Compare with previous version

added 1 commit

• 4c26fbe8 - split blc_strips and md_additional_offset definitions when selected

Compare with previous version

marked this merge request as ready

removed In Progress label

added Testing Waiting for review labels

marked the checklist item To be tested. as completed

I somehow missed the conclusion of whether it is possible to store medians of constants within the constants themselves. blc-stripes is a fairly common feature and thus would still run often to compute a constant value from constant data...

mentioned in merge request !694

removed Testing label

changed milestone to %3.6.2

mentioned in merge request !604 (merged)

Let's postpone any inclusion of extra data the constants for later and get this in.

LGTM, thanks!

added 1 commit

• 3e75afbb - skip median for intercepts as well except for CCV of V0

Compare with previous version

added 282 commits

• 3e75afbb...bdcc0ff3 - 280 commits from branch master
• 978e23a9 - skip PC sanitization with constants of v1
• 00febd8f - skip median for intercepts as well except for CCV of V0

Compare with previous version

resolved all threads

added 4 commits

• 00febd8f...58064bfe - 2 commits from branch master
• cfb4708a - skip PC sanitization with constants of v1
• 67108ca9 - skip median for intercepts as well except for CCV of V0

Compare with previous version

Thanks @schmidtp for the review!

enabled an automatic merge when the pipeline for 67108ca9 succeeds

merged

mentioned in commit 6ab3388a

removed Waiting for review label