Skip to content

[GH2][Correct] Gain constant needs to be float32

Karim Ahmed requested to merge fix/GH2_correct_wrong_gain_dtype into master

This fixes the reported issue at https://redmine.xfel.eu/issues/147905

Description

Corrections were failing because the Cython correction function expected float32 constants. As the gain constant was injected as float64, I made sure that the gain constant is converted to the right type before being used for correction.

Marco was also notified and he will make sure that notebook is injecting gain constant of the expected type.

How Has This Been Tested?

Tested locally and hotfixed in production

Relevant Documents (optional)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@kluyvert @hammerd

Merge request reports