[JUNGFRAU][CORRECT] Add fragment file and remove precorrection notebook
1 unresolved thread
1 unresolved thread
Add fragment file and remove precorrection notebook from JUNGFRA correction.
Description
- remove precorrection notebook.
- copy
write_constants_fragmentfrom !828 (merged) - add sequence number for validation against values of reference corrected runs.
How Has This Been Tested?
Relevant Documents (optional)
Types of changes
- New feature (non-breaking change which adds functionality)
Checklist:
Reviewers
Merge request reports
Activity
Filter activity
added Waiting for review label
assigned to @ahmedk
added 1 commit
- 88acc901 - add proper sequence number for data validation
618 613 " save_reduced_rois(outp_file, data_corr, mask_corr, local_karabo_da)\n", 619 614 "\n", 620 615 " # Create METDATA datasets\n", 621 " outp_file.create_metadata(like=seq_dc)\n", 616 " outp_file.create_metadata(\n", 617 " like=seq_dc,\n", 618 " sequence=seq_dc.run_metadata()[\"sequenceNumber\"],\n", I just added this for the tests to succeed. I think I added this every time for the tests to pass but never pushed the change. I should have added this separately but I was lazy to add a line of code in a separate MR.
Edited by Karim Ahmed
added 46 commits
-
88acc901...83ce1676 - 44 commits from branch
feat/jungfrau_calcat_interface - 3ecb39ec - initial commit
- 04ec257b - add proper sequence number for data validation
-
88acc901...83ce1676 - 44 commits from branch
added 4 commits
-
04ec257b...e728c8cf - 2 commits from branch
feat/jungfrau_calcat_interface - efe7559f - initial commit
- 91625c7a - add proper sequence number for data validation
-
04ec257b...e728c8cf - 2 commits from branch
added 36 commits
-
91625c7a...c1552168 - 33 commits from branch
master - c99c5dfb - initial commit
- eace32f8 - add proper sequence number for data validation
- 5ad18c44 - Refactor: load constants after writing fragment
Toggle commit list-
91625c7a...c1552168 - 33 commits from branch
changed milestone to %3.11.0
mentioned in merge request !845 (merged)
added 124 commits
-
5ad18c44...9da6b743 - 121 commits from branch
master - df22fec2 - initial commit
- 339d1348 - add proper sequence number for data validation
- df904a7b - Refactor: load constants after writing fragment
Toggle commit list-
5ad18c44...9da6b743 - 121 commits from branch
Thank you @kluyvert
mentioned in commit 2bba5cc8
Please register or sign in to reply