Skip to content

[Jungfrau][Correct] New A1256 JF Strixel

Karim Ahmed requested to merge feat/new_jf_strixel_kind into master

Description

This MR addresses the integration for a new JF strixel at SCS

The main purpose of this MR is to integrate the new detector. Additionally, to update the strixel_configuration to be able to update the jfstrixel functions to switch between the different jf strixels we have now at HED(A0123) and SCS(A1256)

As I did previously with epix100 and GH2, I saw this opportunity to collect the Jungfrau modules in a dedicated directory. I have also included the 2 new .npz files which @hammerd produced at calng!76 (merged). This enables us to avoid creating the LUT for every train. This led to removing some functions from jfstrixel.

I updated the dark notebook as well as the test_jungfraulib file to adapt the library path update.

How Has This Been Tested?

  • I used the reference test code to test jfstrixel HED correction compared to with master.
  • I ran as well the correction for jfstrixel with xfel-calibrate.

Relevant Documents (optional)

jfstrixel_A1256.pdf

jfstrixel_A0123.pdf

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactor (refactoring code with no functionality changes)

Checklist:

Reviewers

@hammerd @kluyvert

Edited by Karim Ahmed

Merge request reports