[Jungfrau][Correct] New A1256 JF Strixel

Description

This MR addresses the integration for a new JF strixel at SCS

The main purpose of this MR is to integrate the new detector. Additionally, to update the strixel_configuration to be able to update the jfstrixel functions to switch between the different jf strixels we have now at HED(A0123) and SCS(A1256)

As I did previously with epix100 and GH2, I saw this opportunity to collect the Jungfrau modules in a dedicated directory. I have also included the 2 new .npz files which @hammerd produced at calng!76 (merged). This enables us to avoid creating the LUT for every train. This led to removing some functions from jfstrixel.

I updated the dark notebook as well as the test_jungfraulib file to adapt the library path update.

How Has This Been Tested?

• I used the reference test code to test jfstrixel HED correction compared to with master.
• I ran as well the correction for jfstrixel with xfel-calibrate.

Relevant Documents (optional)

jfstrixel_A1256.pdf

jfstrixel_A0123.pdf

Types of changes

• New feature (non-breaking change which adds functionality)
• Refactor (refactoring code with no functionality changes)

Checklist:

Reviewers

@hammerd @kluyvert

added Waiting for review label

assigned to @ahmedk

Nice work! Two suggestions come to mind:

1. if we're shipping prebaked LUTs, should we just drop the function cal_tools.jungfrau.jfstrixel.double_pixel_indices and instead, in the .npz packages, just include a prebaked mask of funky pixels to scale?
2. it's pretty hard to see the corrected preview in the jfstrixel_A1256.pdf due to the extreme aspect ratio. Should we stretch it in this case? In the notebook Nuno sent me (for reference, most of that is still in /gpfs/exfel/data/scratch/online_calibration/hammerd/notebooks/JF_LGAD_strixel.ipynb which I used for benchmarking), he would just pass aspect=1/3 to imshow.

added 2 commits

• a1bdafea - store double pixels and and load the arrays in the notebook
• 2bea1ec9 - improve the plotting for corrected preview for A1256

Compare with previous version

added 1 commit

• be6b3161 - apply isort and flake8 on jfstrixel

Compare with previous version

added 1 commit

• ced29c5e - aspect for badpix plot

Compare with previous version

added 1 commit

• fbf84e86 - cache get_strixel_parameters

Compare with previous version

changed the description

added 1 commit

• 1bdeec5b - update strxel_cols_A0123 after adding ydouble and xdouble pixels

Compare with previous version

added 1 commit

• a4235405 - fix strixel plotting

Compare with previous version

changed milestone to %3.11.4

added 26 commits

• a4235405...009a148e - 17 commits from branch master
• a56c9394 - New JF Strixel
• 885e11e3 - update imports for DARK NB and TEST afetr moving the library
• c35ede06 - store double pixels and and load the arrays in the notebook
• 168b5a51 - improve the plotting for corrected preview for A1256
• 2eeea818 - apply isort and flake8 on jfstrixel
• 23db3088 - aspect for badpix plot
• a6b62528 - cache get_strixel_parameters
• 6950f7f1 - update strxel_cols_A0123 after adding ydouble and xdouble pixels
• 0c80dd5e - fix strixel plotting

Compare with previous version

added 1 commit

• 73887c77 - make convert aspect condition

Compare with previous version

LGTM

resolved all threads

Thank you David for the review!

enabled an automatic merge when the pipeline for 73887c77 succeeds

removed Waiting for review label

added Update Calibration Configurations! label