[Jungfrau][Correct] New A1256 JF Strixel

Description

This MR addresses the integration for a new JF strixel at SCS

The main purpose of this MR is to integrate the new detector. Additionally, to update the strixel_configuration to be able to update the jfstrixel functions to switch between the different jf strixels we have now at HED(A0123) and SCS(A1256)

As I did previously with epix100 and GH2, I saw this opportunity to collect the Jungfrau modules in a dedicated directory. I have also included the 2 new .npz files which @hammerd produced at calng!76 (merged). This enables us to avoid creating the LUT for every train. This led to removing some functions from jfstrixel.

I updated the dark notebook as well as the test_jungfraulib file to adapt the library path update.

How Has This Been Tested?

• I used the reference test code to test jfstrixel HED correction compared to with master.
• I ran as well the correction for jfstrixel with xfel-calibrate.

Relevant Documents (optional)

jfstrixel_A1256.pdf

jfstrixel_A0123.pdf

Types of changes

• New feature (non-breaking change which adds functionality)
• Refactor (refactoring code with no functionality changes)

Checklist:

Reviewers

@hammerd @kluyvert

src/cal_tools/jungfrau/jfstrixel.py

@@ -5,7 +5,17 @@ from pathlib import Path
 REGULAR_SHAPE = (512, 1024)
 DIR_PATH = package_directory = Path(__file__).resolve().parent
 
+
 def get_strixel_parameters(kind):
+    """Returns a dictionary of strixel parameters stored in .npz file
+    based on the given kind.
+
+    Args:
+        kind (str): Specifies the type of strixel parameters to retrieve.
+            There is two possible values: "A0123" or "A1256"
+    Returns:
+        (dict): Dictionary contating the strixel parameters.
+    """
     strx_parameters = {}
 
     if kind == "A0123":
@@ -39,20 +49,19 @@ def store_double_pixel_indices():
 
     with np.load(file_path) as data:
         for double_col in [765, 1539, 2313]:
-                for col in range(double_col, double_col+12):
-                    for row in range(84 if ((col-double_col) // 4) == 1 else 86):
-                        ydouble.append(row)
-                        xdouble.append(col)
+            for col in range(double_col, double_col+12):
+                for row in range(84 if ((col-double_col) // 4) == 1 else 86):
+                    ydouble.append(row)
+                    xdouble.append(col)
         np.savez(file_path, **data, ydouble=ydouble, xdouble=xdouble)
 
 
-
 def to_strixel(data, out=None, kind="A0123"):
     """Transform from regular to strixel geometry.
 
     Only the last two axes are considered for transformation, input data
     may have any number of additional axes in front.
-    
+
     Args:
         data (array_like): Data in regular geometry.
         out (array_like, optional): Buffer for transformed output, a new
@@ -69,7 +78,8 @@ def to_strixel(data, out=None, kind="A0123"):
     strx = get_strixel_parameters(kind)
 
     if out is None:
-        out = np.zeros((*data.shape[:-2], *strx["frame_shape"]), dtype=data.dtype)
+        out = np.zeros(
+            (*data.shape[:-2], *strx["frame_shape"]), dtype=data.dtype)
 
     out.reshape(*out.shape[:-2], -1)[..., ~strx["mask"]] = data.reshape(
         *data.shape[:-2], -1)[..., strx["lut"]]