[AGIPD] as_single_value instead of get_run_value

Using CONTROL source to read AGIPD conditions using as_single_value.

Description

Replacing get_run_value with as_single_value to read all conditions, except the bias_voltage.

To unify the method for reading the parameter conditions and not fail silently if there is a bug in the CONTROL values.

Except for the bias_voltage, which is known of wrong CONTROL values for AGIPD@HED.

How Has This Been Tested?

Relevant Documents (optional)

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@calibration

mentioned in merge request !651 (merged)

marked this merge request as ready

So I assume it could happen that KeyData.as_single_value throws ValueErrors?

It's kind of reverting to the old behavior of just taking the first value (in a faster way), but reasonable if it causes problems. The danger is that misconfiguration during a run will be silent again.

added 1 commit

• 247b8695 - change from get_run_value to as_single_value

Compare with previous version

changed title from get_run_value instead of as_single_value to [AGIPD] as_single_value instead of get_run_value

mentioned in merge request !647 (merged)

I'm confused, I'm just checking the MRs and:

• Title suggests as_single_value is used
• Code uses as_single_value
• Desecriptions reads:

Using RUN source instead of CONTROL source to read AGIPD conditions.

Replacing as_single_value with get_run_value to read conditions from RUN source.

added Waiting for review label

changed the description

Thanks for the MR, LGTM.

approved this merge request

BTW, you can omit the .value in the keys on control sources, and it will still work. Entirely optional, but sometimes it can make the code easier to read.

changed this line in version 3 of the diff

Thanks, I removed it. I still need to keep it of course, when I am checking if it is one of the keys_for_source

If extra_data is new enough, you could also do that check like:

"integrationTime" in self.run_dc[self.ctrl_src]

There's normally not much difference, but this can be slightly quicker because it doesn't need to find all the keys for that source.

added 1 commit

• cb97275d - no need to convert bias_voltage value to int, Also remove unneeded .value for keys

Compare with previous version

resolved all threads

added 58 commits

• cb97275d...d09e3f59 - 55 commits from branch master
• 3625b297 - get_run_value instead of as_single_value
• 27d82dc7 - change from get_run_value to as_single_value
• bf6c42d5 - no need to convert bias_voltage value to int, Also remove unneeded .value for keys

Compare with previous version

added 1 commit

• 2b656a0b - no need to convert bias_voltage value to int, Also remove unneeded .value for keys

Compare with previous version

merged

mentioned in commit f8321fe9