Skip to content
Snippets Groups Projects

[Generic] Injection code for DynamicFF corrections

Merged Philipp Schmidt requested to merge feat/shimadzu-injection into feat/shimadzu-correction
All threads resolved!

Description

This MR contains the new machinery to write calibration constant files and inject them into CalCat. I decided to have it in its own MR against !939 (merged) for a cleaner diff and independent discussion.

For writing, for now there's only the low-level function write_ccv expecting all kinds of metadata to be passed explicitly. I've been exploring some more convenient APIs to simplify the boilerplate in various notebooks, but let's give this more time. For now the Shimadzu characterization notebook was explicitly written in a way to have this explicit information handy, so let's make use of it.

For injection, there's the original function used for testing and design inject_ccv_legacy that also takes all data explicitly, and a new version to be used from now on that reads most of it from the CCV file created with write_ccv. This is done to allow the webservice to also perform injection on behalf of a user with (almost) just the files at hand.

How Has This Been Tested?

WIP

Types of changes

  • New feature (non-breaking change which adds functionality)

Reviewers

@ahmedk @kluyvert @hammerd

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • David Hammer
  • added 2 commits

    • 7143789a - (fixup) minor formatting fixes
    • ac632c54 - Copy file before injection and delete copy if it fails

    Compare with previous version

  • Philipp Schmidt resolved all threads

    resolved all threads

  • Philipp Schmidt added 11 commits

    added 11 commits

    • ac632c54...70d47451 - 9 commits from branch feat/shimadzu-correction
    • 9eef6ac6 - Add WIP for injection module
    • 3113cb44 - Add actual CCV file creation and injection to DynamicFF characterization

    Compare with previous version

  • This is now the version tested manually from the characterization notebook. Full stack test is pending copying Shimadzu run to test myMdC.

  • Philipp Schmidt added 27 commits

    added 27 commits

    • 3113cb44...1f6bbefa - 24 commits from branch feat/shimadzu-correction
    • bbef486e - Fix small issues and typos from testing Shimadzu corrections
    • b30321e8 - Add proper initialization of CalCatAPIClient and caldb-root via YAML or env
    • 0811d9bc - Add actual CCV file creation and injection to DynamicFF characterization

    Compare with previous version

  • added 1 commit

    • 5a23cc43 - Add actual CCV file creation and injection to DynamicFF characterization

    Compare with previous version

  • added 3 commits

    • 5a23cc43...b4f8ecd2 - 2 commits from branch feat/shimadzu-correction
    • d5d81e9d - Add actual CCV file creation and injection to DynamicFF characterization

    Compare with previous version

  • added 1 commit

    • 8aebbaf1 - Remove legacy version of inject_ccv

    Compare with previous version

  • Merging this into feat/shimadzu-correction after lunch.

  • mentioned in commit 16c1e387

  • Philipp Schmidt changed milestone to %3.14.0

    changed milestone to %3.14.0

  • Please register or sign in to reply
    Loading